[
https://issues.apache.org/jira/browse/HDFS-15712?focusedWorklogId=521016&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-521016
]
ASF GitHub Bot logged work on HDFS-15712:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Dec/20 07:52
Start Date: 07/Dec/20 07:52
Worklog Time Spent: 10m
Work Description: GauthamBanasandra commented on a change in pull request
#2523:
URL: https://github.com/apache/hadoop/pull/2523#discussion_r537295463
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/CMakeLists.txt
##########
@@ -51,6 +54,38 @@ find_package(Threads)
include(CheckCXXSourceCompiles)
+# Download and build gtest
+configure_file(CMakeLists-gtest.txt.in googletest-download/CMakeLists.txt)
+execute_process(COMMAND ${CMAKE_COMMAND} -G "${CMAKE_GENERATOR}" .
+ RESULT_VARIABLE result
+ WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/googletest-download)
+if(result)
+ message(FATAL_ERROR "CMake step for googletest failed: ${result}")
+endif()
+execute_process(COMMAND ${CMAKE_COMMAND} --build .
+ RESULT_VARIABLE result
+ WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/googletest-download)
+if(result)
+ message(FATAL_ERROR "Build step for googletest failed: ${result}")
+endif()
+
+# Prevent overriding the parent project's compiler/linker
+# settings on Windows
+set(gtest_force_shared_crt ON CACHE BOOL "" FORCE)
+
+# Add googletest directly to our build. This defines
+# the gtest and gtest_main targets.
+add_subdirectory(${CMAKE_CURRENT_BINARY_DIR}/googletest-src
+ ${CMAKE_CURRENT_BINARY_DIR}/googletest-build
+ EXCLUDE_FROM_ALL)
+
+# The gtest/gtest_main targets carry header search path
+# dependencies automatically when using CMake 2.8.11 or
+# later. Otherwise we have to add them here ourselves.
+if (CMAKE_VERSION VERSION_LESS 2.8.11)
+ include_directories("${gtest_SOURCE_DIR}/include"
"${gmock_SOURCE_DIR}/include")
+endif()
Review comment:
Done. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 521016)
Time Spent: 1h 50m (was: 1h 40m)
> Upgrade googletest to 1.10.0
> ----------------------------
>
> Key: HDFS-15712
> URL: https://issues.apache.org/jira/browse/HDFS-15712
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build, libhdfs++
> Affects Versions: 3.4.0
> Reporter: Gautham Banasandra
> Assignee: Gautham Banasandra
> Priority: Critical
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> The Google test library used in *libhdfspp* module in the *Hadoop HDFS Native
> Client* project is quite old (about 7 years at the time of this writing).
> Moreover, even though it's third party code, the entire library is checked in
> as part of the Hadoop codebase.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
