[
https://issues.apache.org/jira/browse/HDFS-15730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17253327#comment-17253327
]
Ayush Saxena commented on HDFS-15730:
-------------------------------------
I am not sure post the change in HDFS-14754, this test is relevant or not, I
think it was checking that in case there is a corrupt replica, then excess
replica isn't deleted? which doesn't hold true now.
Having excess replica shouldn't bother reconstruction in general if there are
datanodes available, that would bother only if there is no DN available,
Correct?
Not sure what can be done here, Are we ok with the present behaviour, do we
need to hold replica unless we are done with reconstruction, we can drop this
test or may be tweak as you have done.
[~ferhui] any thoughts on this?
> Erasure Coding: Fix unit test bug of
> TestAddOverReplicatedStripedBlocks.testProcessOverReplicatedAndCorruptStripedBlock.
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-15730
> URL: https://issues.apache.org/jira/browse/HDFS-15730
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Jinglun
> Assignee: Jinglun
> Priority: Minor
> Attachments: HDFS-15730.001.patch
>
>
> I'm working on ec replication and find a bug of the test case:
> TestAddOverReplicatedStripedBlocks#testProcessOverReplicatedAndCorruptStripedBlock.
> The test case added 2 redundant block then check the block indices. It wrote
> 'the redundant internal blocks will not be deleted before the corrupted block
> gets reconstructed.'
> But actually the redundant block could be deleted when there is corrupted
> block. The reason the test could pass is it runs very fast and checks the
> block indices before the redundant block is deleted and reported to the
> NameNode.
> The patch is both a fix and an explanation of the bug.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
