[
https://issues.apache.org/jira/browse/HDFS-15745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256481#comment-17256481
]
Ayush Saxena commented on HDFS-15745:
-------------------------------------
Thanx [~huanghaibin] for the patch. Had a quick look, Minor comments
* Making configurable is Ok, but we should keep the default the value as is.
* You need to add the new conf in hdfs-defaults
* Checkstyle needs to be fixed.
> Make DataNodePeerMetrics#LOW_THRESHOLD_MS and MIN_OUTLIER_DETECTION_NODES
> configurable
> --------------------------------------------------------------------------------------
>
> Key: HDFS-15745
> URL: https://issues.apache.org/jira/browse/HDFS-15745
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Haibin Huang
> Assignee: Haibin Huang
> Priority: Major
> Attachments: HDFS-15745-001.patch, image-2020-12-22-17-00-50-796.png
>
>
> When i enable DataNodePeerMetrics to find slow slow peer in cluster, i found
> there is a lot of slow peer but ReportingNodes's averageDelay is very low,
> and these slow peer node are normal. I think the reason of why generating so
> many slow peer is that the value of DataNodePeerMetrics#LOW_THRESHOLD_MS is
> too small (only 5ms) and it is not configurable. The default value of slow io
> warning log threshold is 300ms, i.e.
> DFSConfigKeys.DFS_DATANODE_SLOW_IO_WARNING_THRESHOLD_DEFAULT = 300, so
> DataNodePeerMetrics#LOW_THRESHOLD_MS should not be less than 300ms, otherwise
> namenode will get a lot of invalid slow peer information.
> !image-2020-12-22-17-00-50-796.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
