[
https://issues.apache.org/jira/browse/HDFS-15766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17260496#comment-17260496
]
Jinglun commented on HDFS-15766:
--------------------------------
Thanks [~ayushtkn] [~elgoiri] your nice comments !
{quote}Why do we need that, we did a mkdir using routerProtocol, the delete
should also work on that?
{quote}
After we fix MockResolver the _routerProtocol.delete(mountPoint,
{color:#910091}true{color});_ will fail because the path is a mount point. In
Router we don't allow renaming a mount point to some new path.
{quote}Can we prevent these missmatches between MockResolver and the regular
ones? Is there some code that we can extract from the regular one and use it in
the MockResolver.
{quote}
Nice suggestion ! Extract the common part into
FileSubclusterResolver.getMountPoints(). Upload v02.
> RBF: MockResolver.getMountPoints() breaks the semantic of
> FileSubclusterResolver.
> ---------------------------------------------------------------------------------
>
> Key: HDFS-15766
> URL: https://issues.apache.org/jira/browse/HDFS-15766
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jinglun
> Assignee: Jinglun
> Priority: Major
> Attachments: HDFS-15766.001.patch
>
>
> MockResolver.getMountPoints() breaks the semantic of
> FileSubclusterResolver.getMountPoints(). Currently it returns null when the
> path is a mount point and no mount points are under the path.
> {quote}Return zero-length list if the path is a mount point but there are no
> mount points under the path.
> {quote}
>
> This is required by router federation rename. I found this bug when writing
> unit test for the rbf rename. Let's fix it here to avoid mixing up with the
> router federation rename.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
