[ 
https://issues.apache.org/jira/browse/HDFS-15769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262610#comment-17262610
 ] 

Xiaoqiao He commented on HDFS-15769:
------------------------------------

Thanks [~xuzq_zander] for your report. cc [~Aiphag0] Please take a look when 
have bandwidth.

> Metric metadataOperationRate maybe incorrect
> --------------------------------------------
>
>                 Key: HDFS-15769
>                 URL: https://issues.apache.org/jira/browse/HDFS-15769
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: xuzq
>            Priority: Major
>
> _metadataOperationRate_ maybe incorrect with the wrong latency in 
> _addFileIoError_. 
>  
> Because _begin_ maybe 0 in _onFailure_ when this FileIo not be sampled.
>  
> Code like:
> {code:java}
> // begin maybe 0 if this FileIo not be sampled.
> public void onFailure(@Nullable FsVolumeSpi volume, long begin) {
>   if (isEnabled) {
>     DataNodeVolumeMetrics metrics = getVolumeMetrics(volume);
>     if (metrics != null) {
>       metrics.addFileIoError(Time.monotonicNow() - begin);
>     }
>   }
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to