[
https://issues.apache.org/jira/browse/HDFS-15782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ning Sheng updated HDFS-15782:
------------------------------
Attachment: HDFS-15782.patch
> RBF: Remove unnecessary expression in StateStoreService
> -------------------------------------------------------
>
> Key: HDFS-15782
> URL: https://issues.apache.org/jira/browse/HDFS-15782
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Ning Sheng
> Priority: Trivial
> Attachments: HDFS-15782.patch
>
>
> {code:java}
> public void refreshCaches(boolean force) {
> boolean success = true;
> if (isDriverReady()) {
> List<StateStoreCache> cachesToUpdate = new LinkedList<>();
> cachesToUpdate.addAll(cachesToUpdateInternal);
> cachesToUpdate.addAll(cachesToUpdateExternal);
> for (StateStoreCache cachedStore : cachesToUpdate) {
> String cacheName = cachedStore.getClass().getSimpleName();
> boolean result = false;
> try {
> result = cachedStore.loadCache(force);
> } catch (IOException e) {
> LOG.error("Error updating cache for {}", cacheName, e);
> result = false;
> }
> if (!result) {
> success = false;
> LOG.error("Cache update failed for cache {}", cacheName);
> }
> }
> } else {
> success = false;
> LOG.info("Skipping State Store cache update, driver is not ready.");
> }
> if (success) {
> // Uses local time, not driver time.
> this.cacheLastUpdateTime = Time.now();
> }
> }{code}
> The expression "result = false;" is unnecessary. Variable result is already
> assigned to false. So we can remove this expression.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
