[ 
https://issues.apache.org/jira/browse/HDFS-15795?focusedWorklogId=543401&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-543401
 ]

ASF GitHub Bot logged work on HDFS-15795:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Jan/21 06:33
            Start Date: 28/Jan/21 06:33
    Worklog Time Spent: 10m 
      Work Description: crossfire commented on a change in pull request #2657:
URL: https://github.com/apache/hadoop/pull/2657#discussion_r565850014



##########
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockChecksumHelper.java
##########
@@ -503,6 +503,7 @@ void compute() throws IOException {
           }
         } catch (IOException e) {

Review comment:
       It may be okay to just remove here instead of rethrowing exception 
because it is handled below too:
   
https://github.com/apache/hadoop/blob/f8769e0f4b917d9fda8ff7a9fddb4d755d246a1e/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java#L324




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 543401)
    Time Spent: 20m  (was: 10m)

> Returned wrong checksum when reconstruction was failed by exception
> -------------------------------------------------------------------
>
>                 Key: HDFS-15795
>                 URL: https://issues.apache.org/jira/browse/HDFS-15795
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode, ec, erasure-coding
>            Reporter: Yushi Hayasaka
>            Assignee: Yushi Hayasaka
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> If the reconstruction task is failed on StripedBlockChecksumReconstructor by 
> exception, the checksum becomes wrong one because it is calculated with 
> blocks without a failure one.
> It is caused by catching exception with not appropriate way, so we need to 
> fix it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to