[
https://issues.apache.org/jira/browse/HDFS-15619?focusedWorklogId=545415&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-545415
]
ASF GitHub Bot logged work on HDFS-15619:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Feb/21 16:03
Start Date: 01/Feb/21 16:03
Worklog Time Spent: 10m
Work Description: bshashikant commented on a change in pull request #2595:
URL: https://github.com/apache/hadoop/pull/2595#discussion_r567939782
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/metrics/NameNodeMetrics.java
##########
@@ -459,4 +472,23 @@ public void addEditLogTailInterval(long elapsed) {
q.add(elapsed);
}
}
+ public void incrNumSnapshotDelete() {
+ numSnapshotTotalDeleteOp.incr();
Review comment:
Its already an existing metric...Let's remove it.
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/SnapshotManager.java
##########
@@ -519,6 +520,14 @@ public void deleteSnapshot(final INodesInPath iip, final
String snapshotName,
final List<XAttr> xattrs = Lists.newArrayListWithCapacity(1);
xattrs.add(snapshotXAttr);
+ // Check if snapshot is already marked as deleted.
+ // If already marked deleted, metric for out of order snapshot deletion
+ // won't be incremented.
+ XAttr existingXAttr = FSDirXAttrOp.getXAttrByPrefixedName(
+ fsdir, INodesInPath.append(iip, snapshot.getRoot(),
Review comment:
we can use snaphot.getRoot().isMarkedAsDeleted() here instead?
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/metrics/NameNodeMetrics.java
##########
@@ -459,4 +472,23 @@ public void addEditLogTailInterval(long elapsed) {
q.add(elapsed);
}
}
+ public void incrNumSnapshotDelete() {
+ numSnapshotTotalDeleteOp.incr();
+ }
+ public void incrOutOfOrderSnapshotDelete() {
+ numSnapshotOutOfOrderDeleteOp.incr();
+ }
+ public void incrInOrderSnapshotDelete() {
+ numSnapshotInOrderDeleteOp.incr();
+ }
Review comment:
its better to move these 2 metrics to SnapshotMetrcics.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 545415)
Time Spent: 1.5h (was: 1h 20m)
> Metric for ordered snapshot deletion GC thread
> ----------------------------------------------
>
> Key: HDFS-15619
> URL: https://issues.apache.org/jira/browse/HDFS-15619
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs
> Reporter: Nilotpal Nandi
> Assignee: Nilotpal Nandi
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Following info should be captured and shown in JMX for garbage collection
> thread of ordered snapshot deletion
> * metric for all pending snapshots to be GCed
> * Number of times GC thread ran
> * Number of Snapshots already GCed
> * Average time taken by each GC run
> * Thread running Status
> * metric for failed deletion of GC thread
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
