[ 
https://issues.apache.org/jira/browse/HDFS-15757?focusedWorklogId=545789&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-545789
 ]

ASF GitHub Bot logged work on HDFS-15757:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Feb/21 04:32
            Start Date: 02/Feb/21 04:32
    Worklog Time Spent: 10m 
      Work Description: goiri commented on a change in pull request #2651:
URL: https://github.com/apache/hadoop/pull/2651#discussion_r568315959



##########
File path: 
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/ConnectionContext.java
##########
@@ -57,6 +62,17 @@ public synchronized boolean isActive() {
     return this.numThreads > 0;
   }
 
+  /**
+   * Check if the connection is/was active recently.
+   *
+   * @return True if the connection is active or
+   * was active in the past period of time.
+   */
+  public synchronized boolean isActiveRecently() {
+    return isActive() ||

Review comment:
       If we do the timestamp based, do we even need to check for the 
isActive() or the timestamp comparisson is enoug?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 545789)
    Time Spent: 1h 40m  (was: 1.5h)

> RBF: Improving Router Connection Management
> -------------------------------------------
>
>                 Key: HDFS-15757
>                 URL: https://issues.apache.org/jira/browse/HDFS-15757
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: rbf
>            Reporter: Fengnan Li
>            Assignee: Fengnan Li
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: RBF_ Improving Router Connection Management_v2.pdf, RBF_ 
> Improving Router Connection Management_v3.pdf, RBF_ Router Connection 
> Management.pdf
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> We have seen high number of connections from Router to namenodes, leaving 
> namenodes unstable.
> This ticket is trying to reduce connections through some changes. Please take 
> a look at the design and leave comments. 
> Thanks!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to