[
https://issues.apache.org/jira/browse/HDFS-15683?focusedWorklogId=547473&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-547473
]
ASF GitHub Bot logged work on HDFS-15683:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Feb/21 07:36
Start Date: 04/Feb/21 07:36
Worklog Time Spent: 10m
Work Description: Jing9 commented on a change in pull request #2625:
URL: https://github.com/apache/hadoop/pull/2625#discussion_r570000126
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
##########
@@ -815,6 +815,25 @@ public IOException call() {
String.format("FAILED TO ADD: %s: %s%n",
volume, ioe.getMessage()));
LOG.error("Failed to add volume: {}", volume, ioe);
+ /**
+ * TODO: Some cases are not supported yet with
+ * same-disk-tiering on. For example, when replacing a
+ * storage directory on same mount, we have check if same
+ * storage type already exists on the mount. In this case
+ * we need to remove existing vol first then add.
+ * Also, we will need to adjust new capacity ratio when
+ * refreshVolume in the future.
+ */
+ if (ioe.getMessage()
Review comment:
It may be better to check if there is conflict with the
same-disk-tiering feature when we first load the refreshVolume configuration.
I.e., we can do some verification on changedVolumes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 547473)
Time Spent: 2.5h (was: 2h 20m)
> Allow configuring DISK/ARCHIVE capacity for individual volumes
> --------------------------------------------------------------
>
> Key: HDFS-15683
> URL: https://issues.apache.org/jira/browse/HDFS-15683
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode
> Reporter: Leon Gao
> Assignee: Leon Gao
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> This is a follow-up task for https://issues.apache.org/jira/browse/HDFS-15548
> In case that the datanode disks are not unified, we should allow admins to
> configure capacity for individual volumes on top of the default one.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
