[
https://issues.apache.org/jira/browse/HDFS-15817?focusedWorklogId=549404&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-549404
]
ASF GitHub Bot logged work on HDFS-15817:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Feb/21 06:29
Start Date: 08/Feb/21 06:29
Worklog Time Spent: 10m
Work Description: bshashikant commented on pull request #2677:
URL: https://github.com/apache/hadoop/pull/2677#issuecomment-774905417
> The changes generally look good. However, if a user again deletes a
deleted snapshot with the new name(which was given because of this rename. Can
we lead into concats of the snapid ?
Yes, it will append the snap id. The behaviour will be same if user for
example, creates a snapshot with the same name as snapshot format and deletes
it . I guess, this should be fine as marked for deleted snapshots are user
visible and can be deleted again and again until and unless it gets permanently
deleted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 549404)
Time Spent: 1h 40m (was: 1.5h)
> Rename snapshots while marking them deleted
> --------------------------------------------
>
> Key: HDFS-15817
> URL: https://issues.apache.org/jira/browse/HDFS-15817
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> With ordered snapshot feature turned on, a snapshot will be just marked as
> deleted but won't actually be deleted if its not the oldest one. Since, the
> snapshot is just marked deleted, creation of new snapshot having the same
> name as the one which was marked deleted will fail. In order to mitigate such
> problems, the idea here is to rename the snapshot getting marked as deleted
> by appending deletion timestamp along with snapshot id to it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
