[
https://issues.apache.org/jira/browse/HDFS-15423?focusedWorklogId=553287&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-553287
]
ASF GitHub Bot logged work on HDFS-15423:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Feb/21 00:53
Start Date: 17/Feb/21 00:53
Worklog Time Spent: 10m
Work Description: fengnanli commented on a change in pull request #2605:
URL: https://github.com/apache/hadoop/pull/2605#discussion_r577245100
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterWebHdfsMethods.java
##########
@@ -0,0 +1,143 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hdfs.server.federation.router;
+
+import static
org.apache.hadoop.hdfs.server.federation.FederationTestUtils.createMountTableEntry;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
+
+import java.io.FileNotFoundException;
+import java.net.HttpURLConnection;
+import java.net.URL;
+import java.util.Collections;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import
org.apache.hadoop.hdfs.server.federation.MiniRouterDFSCluster.RouterContext;
+import org.apache.hadoop.hdfs.server.federation.RouterConfigBuilder;
+import org.apache.hadoop.hdfs.server.federation.StateStoreDFSCluster;
+import
org.apache.hadoop.hdfs.server.federation.resolver.order.DestinationOrder;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Test suite for Router Web Hdfs methods.
+ */
+public class TestRouterWebHdfsMethods {
+ static final Logger LOG =
+ LoggerFactory.getLogger(TestRouterWebHdfsMethods.class);
+
+ private static StateStoreDFSCluster cluster;
+ private static RouterContext router;
+ private static String httpUri;
+
+ @BeforeClass
+ public static void globalSetUp() throws Exception {
+ cluster = new StateStoreDFSCluster(false, 2);
+ Configuration conf = new RouterConfigBuilder()
+ .stateStore()
+ .rpc()
+ .http()
+ .admin()
+ .build();
+ cluster.addRouterOverrides(conf);
+ cluster.startCluster();
+ cluster.startRouters();
+ cluster.waitClusterUp();
+ router = cluster.getRandomRouter();
+ httpUri = "http://"+router.getHttpAddress();
+ }
+
+ @AfterClass
+ public static void tearDown() {
+ if (cluster != null) {
+ cluster.shutdown();
+ cluster = null;
+ }
+ }
+
+ @Test
+ public void testWebHdfsCreate() throws Exception {
+ // the file is created at default ns (ns0)
+ String path = "/tmp/file";
+ URL url = new URL(getUri(path));
+ LOG.info("URL: {}", url);
+ HttpURLConnection conn = (HttpURLConnection) url.openConnection();
+ conn.setRequestMethod("PUT");
+ assertEquals(HttpURLConnection.HTTP_CREATED, conn.getResponseCode());
+ verifyFile("ns0", path, true);
+ verifyFile("ns1", path, false);
+ conn.disconnect();
+ }
+
+ @Test
+ public void testWebHdfsCreateWithMounts() throws Exception {
+ // the file is created at mounted ns (ns1)
+ String mountPoint = "/tmp-ns1";
+ String path = "/tmp-ns1/file";
+ createMountTableEntry(
+ router.getRouter(), mountPoint,
+ DestinationOrder.RANDOM, Collections.singletonList("ns1"));
+ URL url = new URL(getUri(path));
+ LOG.info("URL: {}", url);
+ HttpURLConnection conn = (HttpURLConnection) url.openConnection();
+ conn.setRequestMethod("PUT");
+ assertEquals(HttpURLConnection.HTTP_CREATED, conn.getResponseCode());
+ verifyFile("ns1", path, true);
+ verifyFile("ns0", path, false);
+ conn.disconnect();
+ }
+
+ private String getUri(String path) {
+ final String user = System.getProperty("user.name");
+ final StringBuilder uri = new StringBuilder(httpUri);
+ uri.append("/webhdfs/v1").
+ append(path).
+ append("?op=CREATE").
+ append("&user.name=" + user);
+ return uri.toString();
+ }
+
+ private void verifyFile(String ns, String path, boolean shouldExist)
+ throws Exception {
+ FileSystem fs = cluster.getNamenode(ns, null).getFileSystem();
+ try {
+ fs.getFileStatus(new Path(path));
+ if (!shouldExist) {
+ fail(path + " should not exist in ns " + ns);
+ }
+ } catch (FileNotFoundException e) {
+ if (shouldExist) {
+ fail(path + " should exist in ns " + ns);
+ }
+ }
+ }
+
+ @Test
+ public void testGetNsFromDataNodeNetworkLocation() {
+ assertEquals("ns0", RouterWebHdfsMethods
+ .getNsFromDataNodeNetworkLocation("/ns0/rack-info1"));
Review comment:
Good catch! I made some change to the regex to make it more accurate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 553287)
Time Spent: 5.5h (was: 5h 20m)
> RBF: WebHDFS create shouldn't choose DN from all sub-clusters
> -------------------------------------------------------------
>
> Key: HDFS-15423
> URL: https://issues.apache.org/jira/browse/HDFS-15423
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: rbf, webhdfs
> Reporter: Chao Sun
> Assignee: Fengnan Li
> Priority: Major
> Labels: pull-request-available
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> In {{RouterWebHdfsMethods}} and for a {{CREATE}} call, {{chooseDatanode}}
> first gets all DNs via {{getDatanodeReport}}, and then randomly pick one from
> the list via {{getRandomDatanode}}. This logic doesn't seem correct as it
> should pick a DN for the specific cluster(s) of the input {{path}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
