[
https://issues.apache.org/jira/browse/HDFS-15808?focusedWorklogId=554447&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-554447
]
ASF GitHub Bot logged work on HDFS-15808:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Feb/21 20:18
Start Date: 18/Feb/21 20:18
Worklog Time Spent: 10m
Work Description: shvachko commented on pull request #2668:
URL: https://github.com/apache/hadoop/pull/2668#issuecomment-781609671
Just reposting my comment on the jira for visibility.
The patch looks fine, but I doubt the metric will be useful in its current
form. Monotonically increasing counter doesn't tell you much when plotted. Over
time it just becomes an incredibly large number, hard to see its fluctuations.
And you cannot set alerts if the threshold is exceeded often.
See e.g. ExpiredHeartbeats or LastWrittenTransactionId - not useful.
I assume you need something like a rate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 554447)
Time Spent: 4h 10m (was: 4h)
> Add metrics for FSNamesystem read/write lock hold long time
> -----------------------------------------------------------
>
> Key: HDFS-15808
> URL: https://issues.apache.org/jira/browse/HDFS-15808
> Project: Hadoop HDFS
> Issue Type: Wish
> Components: hdfs
> Reporter: tomscut
> Assignee: tomscut
> Priority: Major
> Labels: hdfs, lock, metrics, pull-request-available
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> To monitor how often read/write locks exceed thresholds, we can add two
> metrics(ReadLockWarning/WriteLockWarning), which are exposed in JMX.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
