[ 
https://issues.apache.org/jira/browse/HDFS-15862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhengxi Li updated HDFS-15862:
------------------------------
           Description: 
The 'org.apache.hadoop.hdfs.nfs.nfs3.TestViewfsWithNfs3.testNfsRenameSingleNN' 
test is not idempotent and fails if run twice in the same JVM, because it 
pollutes state shared among tests. It may be good to clean this state pollution 
so that some other tests do not fail in the future due to the shared state 
polluted by this test.

Running {{TestViewfsWithNfs3.testNfsRenameSingleNN}} twice would result in the 
second run failing with a NullPointer exception:
{noformat}
[ERROR] Errors:
[ERROR]   TestViewfsWithNfs3.testNfsRenameSingleNN:317 NullPointer
{noformat}
The reason for this is that the {{/user1/renameSingleNN}} file is created in 
{{setup()}}, but gets renamed in {{testNfsRenameSingl{{eNN}}}}. When the second 
run of {{testNfsRenameSingleNN}} tries to get info of the file by its original 
name, it returns a NullPointer since the file no longer exists.

 

Link to PR: https://github.com/apache/hadoop/pull/2724

  was:
The 'org.apache.hadoop.hdfs.nfs.nfs3.TestViewfsWithNfs3.testNfsRenameSingleNN' 
test is not idempotent and fails if run twice in the same JVM, because it 
pollutes state shared among tests. It may be good to clean this state pollution 
so that some other tests do not fail in the future due to the shared state 
polluted by this test.

Running {{TestViewfsWithNfs3.testNfsRenameSingleNN}} twice would result in the 
second run failing with a NullPointer exception:
{noformat}
[ERROR] Errors:
[ERROR]   TestViewfsWithNfs3.testNfsRenameSingleNN:317 NullPointer
{noformat}
The reason for this is that the {{/user1/renameSingleNN}} file is created in 
{{setup()}}, but gets renamed in {{testNfsRenameSingl{{eNN}}}}. When the second 
run of {{testNfsRenameSingleNN}} tries to get info of the file by its original 
name, it returns a NullPointer since the file no longer exists.

                Labels:   (was: pull-request-available)
    Remaining Estimate:     (was: 0h)

> Rename file back to original in TestViewfsWithNfs3.testNfsRenameSingleNN
> ------------------------------------------------------------------------
>
>                 Key: HDFS-15862
>                 URL: https://issues.apache.org/jira/browse/HDFS-15862
>             Project: Hadoop HDFS
>          Issue Type: Test
>            Reporter: Zhengxi Li
>            Assignee: Zhengxi Li
>            Priority: Minor
>          Time Spent: 10m
>
> The 
> 'org.apache.hadoop.hdfs.nfs.nfs3.TestViewfsWithNfs3.testNfsRenameSingleNN' 
> test is not idempotent and fails if run twice in the same JVM, because it 
> pollutes state shared among tests. It may be good to clean this state 
> pollution so that some other tests do not fail in the future due to the 
> shared state polluted by this test.
> Running {{TestViewfsWithNfs3.testNfsRenameSingleNN}} twice would result in 
> the second run failing with a NullPointer exception:
> {noformat}
> [ERROR] Errors:
> [ERROR]   TestViewfsWithNfs3.testNfsRenameSingleNN:317 NullPointer
> {noformat}
> The reason for this is that the {{/user1/renameSingleNN}} file is created in 
> {{setup()}}, but gets renamed in {{testNfsRenameSingl{{eNN}}}}. When the 
> second run of {{testNfsRenameSingleNN}} tries to get info of the file by its 
> original name, it returns a NullPointer since the file no longer exists.
>  
> Link to PR: https://github.com/apache/hadoop/pull/2724



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to