[
https://issues.apache.org/jira/browse/HDFS-15384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296788#comment-17296788
]
Xiaoqiao He commented on HDFS-15384:
------------------------------------
{quote}If you find any place, you can improve the documentation, else if it is
a public API, you can add proper Javadoc's explaining this. This is the most
that I feel can be done here
{quote}
+1. Please be careful to changing behavior of a public API.
For improving the Javadoc, do not see v004 patch, based on v003 we could offer
more information for Javadoc as following example.
{quote}Get locations of the blocks of the specified file `src` from offset
`start` within the prefetch size which is related to parameter
`dfs.client.read.prefetch.size`. DataNode locations for each block are sorted
by the proximity to the client. Please note that the prefetch size is not equal
file length generally.{quote}
> Method getLocatedBlocks(String src, long start) of DFSClient only return
> partial blocks
> ---------------------------------------------------------------------------------------
>
> Key: HDFS-15384
> URL: https://issues.apache.org/jira/browse/HDFS-15384
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Yang Yun
> Assignee: Yang Yun
> Priority: Minor
> Attachments: HDFS-15384.001.patch, HDFS-15384.002.patch,
> HDFS-15384.003.patch
>
>
>
>
> Intuitively, the method getLocatedBlocks(String src, long start) of DFSClient
> will return all blocks after offset ‘start’. But actually it uses
> dfsClientConf.getPrefetchSize() as the length and only return part of blocks.
> I feel it's error-prone and open this Jira for discussion.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
