[ 
https://issues.apache.org/jira/browse/HDFS-15842?focusedWorklogId=562160&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-562160
 ]

ASF GitHub Bot logged work on HDFS-15842:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Mar/21 07:28
            Start Date: 08/Mar/21 07:28
    Worklog Time Spent: 10m 
      Work Description: Jing9 commented on a change in pull request #2738:
URL: https://github.com/apache/hadoop/pull/2738#discussion_r589216233



##########
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/mover/Mover.java
##########
@@ -649,6 +664,11 @@ static int run(Map<URI, List<Path>> namenodes, 
Configuration conf)
     Map<Long, Set<DatanodeInfo>> excludedPinnedBlocks = new HashMap<>();
     LOG.info("namenodes = " + namenodes);
 
+    DefaultMetricsSystem.initialize("Mover");

Review comment:
       Does Balancer have a similar metrics? If not shall we use this PR or 
create a new one to do that?

##########
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/mover/package-info.java
##########
@@ -0,0 +1,27 @@
+/**

Review comment:
       Do we need to add this file?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 562160)
    Time Spent: 20m  (was: 10m)

> HDFS mover to emit metrics
> --------------------------
>
>                 Key: HDFS-15842
>                 URL: https://issues.apache.org/jira/browse/HDFS-15842
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: balancer &amp; mover
>            Reporter: Leon Gao
>            Assignee: Leon Gao
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> We can emit metrics thru metrics2 when running HDFS mover, which can help to 
> monitor the progress and turn mover parameters.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to