[
https://issues.apache.org/jira/browse/HDFS-15855?focusedWorklogId=562424&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-562424
]
ASF GitHub Bot logged work on HDFS-15855:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Mar/21 15:56
Start Date: 08/Mar/21 15:56
Worklog Time Spent: 10m
Work Description: goiri commented on a change in pull request #2741:
URL: https://github.com/apache/hadoop/pull/2741#discussion_r589533032
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestEnabledECPolicies.java
##########
@@ -143,7 +143,7 @@ public void testChangeDefaultPolicy() throws Exception {
testPolicy);
manager.init(conf);
// Load policies similar to when fsimage is loaded at namenode startup
- manager.loadPolicies(constructAllDisabledInitialPolicies(), conf);
+ manager.loadPolicies(constructAllDisabledInitialPolicies(), conf, null);
Review comment:
Can we add a test with the counter being passed?
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java
##########
@@ -482,11 +483,15 @@ private void loadPolicy(ErasureCodingPolicyInfo info) {
*
*/
public synchronized void loadPolicies(
- List<ErasureCodingPolicyInfo> ecPolicies, Configuration conf)
+ List<ErasureCodingPolicyInfo> ecPolicies, Configuration conf,
Review comment:
Can you leave the old header passing a null so we don't need to modify
the tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 562424)
Time Spent: 40m (was: 0.5h)
> Solve the problem of incorrect EC progress when loading FsImage
> ---------------------------------------------------------------
>
> Key: HDFS-15855
> URL: https://issues.apache.org/jira/browse/HDFS-15855
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: JiangHua Zhu
> Assignee: JiangHua Zhu
> Priority: Major
> Labels: pull-request-available
> Attachments: ec_progress.jpg
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When loading FsImage, if EC information exists, the EC loading display is
> incorrect during processing.
> FSImageFormatProtobuf#loadInternal() :
> case ERASURE_CODING:
> Step step = new Step(StepType.ERASURE_CODING_POLICIES);
> prog.beginStep(Phase.LOADING_FSIMAGE, step);
> loadErasureCodingSection(in);
> prog.endStep(Phase.LOADING_FSIMAGE, step);
> break;
> StartupProgress is not used here to record EC-related information.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
