[ 
https://issues.apache.org/jira/browse/HDFS-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300749#comment-17300749
 ] 

Xiaoqiao He commented on HDFS-15816:
------------------------------------

Thanks [~hadoop_yangyun] for your works. 
Please fix the codestyle of the following segment. It seems to miss space 
somewhere...
{code:java}
+    for(int i=0; i<6; i++) {
+      updateHeartbeatWithUsage(dataNodes[i],
+          2* HdfsServerConstants.MIN_BLOCKS_FOR_WRITE*BLOCK_SIZE, 0L,
+          (HdfsServerConstants.MIN_BLOCKS_FOR_WRITE-1)*BLOCK_SIZE,
+          0L, 0L, 0L, 0, 0);
+    }
{code}
Will give my +1 on [^HDFS-15816.003.patch] when update.

> If NO stale node in cluster, the function shouldAvoidStaleDataNodesForWrite 
> should return false.
> ------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-15816
>                 URL: https://issues.apache.org/jira/browse/HDFS-15816
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: block placement
>            Reporter: Yang Yun
>            Assignee: Yang Yun
>            Priority: Minor
>         Attachments: HDFS-15816.001.patch, HDFS-15816.002.patch, 
> HDFS-15816.003.patch
>
>
> If NO stale node in cluster, the function shouldAvoidStaleDataNodesForWrite 
> should return false.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to