[ 
https://issues.apache.org/jira/browse/HDFS-15906?focusedWorklogId=569503&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-569503
 ]

ASF GitHub Bot logged work on HDFS-15906:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Mar/21 02:39
            Start Date: 22/Mar/21 02:39
    Worklog Time Spent: 10m 
      Work Description: tomscut commented on pull request #2788:
URL: https://github.com/apache/hadoop/pull/2788#issuecomment-803722823


   > @tomscut Thanks for the PR. Some minor comments:
   > 
   > * Maybe `fsn.close()` should be in the finally scope too.
   > * It is better to verify that `fsn` and `fsImage` are not null before 
closing them.
   
   Thanks @tasanuma  for your kind review and suggestions, I fixed them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 569503)
    Time Spent: 1h  (was: 50m)

> Close FSImage and FSNamesystem after formatting is complete
> -----------------------------------------------------------
>
>                 Key: HDFS-15906
>                 URL: https://issues.apache.org/jira/browse/HDFS-15906
>             Project: Hadoop HDFS
>          Issue Type: Wish
>            Reporter: tomscut
>            Assignee: tomscut
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Close FSImage and FSNamesystem after formatting is complete. 
> org.apache.hadoop.hdfs.server.namenode#format.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to