[
https://issues.apache.org/jira/browse/HDFS-15931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mingliang Liu updated HDFS-15931:
---------------------------------
Fix Version/s: 3.2.3
2.10.2
3.1.5
3.4.0
3.3.1
Hadoop Flags: Reviewed
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed to all fixed versions. Thanks!
> Fix non-static inner classes for better memory management
> ---------------------------------------------------------
>
> Key: HDFS-15931
> URL: https://issues.apache.org/jira/browse/HDFS-15931
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.3.1, 3.4.0, 3.1.5, 2.10.2, 3.2.3
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> If an inner class does not need to reference its enclosing instance, it can
> be static. This prevents a common cause of memory leaks and uses less memory
> per instance of the enclosing class.
> Came across DataNodeProperties as a non static inner class defined in
> MiniDFSCluster without holding any implicit reference to MiniDFSCluster.
> Taking this opportunity to find other non-static inner classes that are not
> holding implicit reference to their respective enclosing instances.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
