[
https://issues.apache.org/jira/browse/HDFS-15939?focusedWorklogId=575873&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-575873
]
ASF GitHub Bot logged work on HDFS-15939:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/21 02:17
Start Date: 02/Apr/21 02:17
Worklog Time Spent: 10m
Work Description: liuml07 commented on a change in pull request #2841:
URL: https://github.com/apache/hadoop/pull/2841#discussion_r606038591
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiverServer.java
##########
@@ -241,6 +241,13 @@ public void run() {
.start();
} catch (SocketTimeoutException ignored) {
// wake up to see if should continue to run
+ if (peer != null) {
+ LOG.warn("A timeout occurred between DataXceiverServer: {} " +
Review comment:
1. Let's rename the `ignored` to ste as now we are not ignoring it.
2. Let's not use warn level here. This seems not a concern for this timeout
exception generally. I think info this level and `debug` for the `else` clause
should be enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 575873)
Time Spent: 0.5h (was: 20m)
> Solve the problem that DataXceiverServer#run() does not record SocketTimeout
> exception
> --------------------------------------------------------------------------------------
>
> Key: HDFS-15939
> URL: https://issues.apache.org/jira/browse/HDFS-15939
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: JiangHua Zhu
> Assignee: JiangHua Zhu
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In DataXceiverServer#run(), if a SocketTimeout exception occurs, no
> information will be recorded here.
> try {
> ......
> } catch (SocketTimeoutException ignored){
> // wake up to see if should continue to run
> }
> No records are generated here, which is not conducive to troubleshooting.
> We should add some warning type logs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
