[
https://issues.apache.org/jira/browse/HDFS-15931?focusedWorklogId=575919&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-575919
]
ASF GitHub Bot logged work on HDFS-15931:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/21 05:42
Start Date: 02/Apr/21 05:42
Worklog Time Spent: 10m
Work Description: liuml07 commented on pull request #2830:
URL: https://github.com/apache/hadoop/pull/2830#issuecomment-812331417
Right right, the PR title is as this one shows now - without "Contributed
by...".
```
HADOOP-12345. Fix foo.
```
When committing, this "Contributed by ..." will be added into subject/
title. I also seen people keep this in commit message.
My comment was more about `:` vs `.`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 575919)
Time Spent: 2.5h (was: 2h 20m)
> Fix non-static inner classes for better memory management
> ---------------------------------------------------------
>
> Key: HDFS-15931
> URL: https://issues.apache.org/jira/browse/HDFS-15931
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.3.1, 3.4.0, 3.1.5, 2.10.2, 3.2.3
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> If an inner class does not need to reference its enclosing instance, it can
> be static. This prevents a common cause of memory leaks and uses less memory
> per instance of the enclosing class.
> Came across DataNodeProperties as a non static inner class defined in
> MiniDFSCluster without holding any implicit reference to MiniDFSCluster.
> Taking this opportunity to find other non-static inner classes that are not
> holding implicit reference to their respective enclosing instances.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
