[
https://issues.apache.org/jira/browse/HDFS-15953?focusedWorklogId=578104&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-578104
]
ASF GitHub Bot logged work on HDFS-15953:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Apr/21 03:53
Start Date: 07/Apr/21 03:53
Worklog Time Spent: 10m
Work Description: Hexiaoqiao commented on pull request #2872:
URL: https://github.com/apache/hadoop/pull/2872#issuecomment-814580627
Thanks @kihwal for your comments. I totally agree with you after dig code
and original design carefully. AND thanks @WeisonWei for your kindly report.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 578104)
Time Spent: 1h 10m (was: 1h)
> DUMMY_CLIENT_ID's verification may be invalid
> ---------------------------------------------
>
> Key: HDFS-15953
> URL: https://issues.apache.org/jira/browse/HDFS-15953
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Xiaoxing Wei
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> *_rpcClientId != RpcConstants.DUMMY_CLIENT_ID_* in *_FSEditLogOp#hasRpcIds()_*
> {code:java}
> // code placeholder
> public boolean hasRpcIds() {
> return rpcClientId != RpcConstants.DUMMY_CLIENT_ID
> && rpcCallId != RpcConstants.INVALID_CALL_ID;
> }
> {code}
>
> determine that two arrays are equal should use "Arrays.equals"
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
