[ 
https://issues.apache.org/jira/browse/HDFS-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175586#comment-13175586
 ] 

Hadoop QA commented on HDFS-2712:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12508558/HDFS-2712.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    -1 javadoc.  The javadoc tool appears to have generated 20 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs (version 1.3.9) 
warnings.

    -1 release audit.  The applied patch generated 1 release audit warnings 
(more than the trunk's current 0 warnings).

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.hdfs.web.TestFSMainOperationsWebHdfs
                  org.apache.hadoop.hdfs.web.TestWebHdfsFileSystemContract

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/1737//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-HDFS-Build/1737//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HDFS-Build/1737//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1737//console

This message is automatically generated.
                
> setTimes should support only for files and move the atime field down to 
> iNodeFile.
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-2712
>                 URL: https://issues.apache.org/jira/browse/HDFS-2712
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>         Attachments: HDFS-2712.patch
>
>
> After the dicussion in HDFS-2436, unsupported behaviour for setTimes was 
> intentional (HADOOP-1869).
> But current INode structure hierarchy seems, it supports atime for 
> directories also. But as per HADOOP-1869, we are supporting only for files. 
> To avoid the confusions, we can move the atime fields to INodeFile as we 
> planned to support setTimes only for files. And also restrict the support for 
> setTimes on directories ( which is implemented with HDFS-2436 ).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to