[
https://issues.apache.org/jira/browse/HDFS-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175809#comment-13175809
]
Harsh J commented on HDFS-2722:
-------------------------------
The findbugs reported here is really odd. Does appear unrelated to this config
wrapping patch.
bq. Class org.apache.hadoop.hdfs.tools.GetConf$Command defines non-transient
non-serializable instance field handler
bq. This Serializable class defines a non-primitive instance field which is
neither transient, Serializable, or java.lang.Object, and does not appear to
implement the Externalizable interface or the readObject() and writeObject()
methods. Objects of this class will not be deserialized correctly if a
non-Serializable object is stored in this field.
What makes this odd is that GetConf.java was not touched since September 2011
per {{viewvc}}. Why would this appear now?
> HttpFs shouldn't be using an int for block size
> -----------------------------------------------
>
> Key: HDFS-2722
> URL: https://issues.apache.org/jira/browse/HDFS-2722
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs client
> Reporter: Harsh J
> Assignee: Harsh J
> Attachments: HDFS-2722.patch
>
>
> {{./hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/FSOperations.java:
> blockSize = fs.getConf().getInt("dfs.block.size", 67108864);}}
> Should instead be using dfs.blocksize and should instead be long.
> I'll post a patch for this after HDFS-1314 is resolved -- which changes the
> internal behavior a bit (should be getLongBytes, and not just getLong, to
> gain formatting advantages).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
