[ 
https://issues.apache.org/jira/browse/HDFS-15980?focusedWorklogId=584393&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-584393
 ]

ASF GitHub Bot logged work on HDFS-15980:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Apr/21 17:23
            Start Date: 16/Apr/21 17:23
    Worklog Time Spent: 10m 
      Work Description: uzshao opened a new pull request #2921:
URL: https://github.com/apache/hadoop/pull/2921


   See https://issues.apache.org/jira/browse/HDFS-15980
   
   
   HDFS-15754 introduces 4 new metrics in DataNodeMetrics.  However the test 
associated with the patch has some bugs.  This issue is to fix those bugs in 
the tests.
   
   Please note that the non-test code of HDFS-15754 worked fine without any 
bugs.
   
   There are 3 issues:
   1. The metric names in the tests were incorrect;
   2. The tests only checked the metrics of DataNode 0, but one of the metrics, 
PacketsSlowWriteToMirror,  is only updated on 2 of the 3 DataNodes, so this 
created an indeterministic failure.
   3. The metric PacketsSlowWriteToOsCache was not updated in the test due to 
the fact that the size of the file was smaller than 
BlockReceiver.CACHE_DROP_LAG_BYTES
   
   All of them are fixed in this patch.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

            Worklog Id:     (was: 584393)
    Remaining Estimate: 0h
            Time Spent: 10m

> Fix tests for HDFS-15754 Create packet metrics for DataNode
> -----------------------------------------------------------
>
>                 Key: HDFS-15980
>                 URL: https://issues.apache.org/jira/browse/HDFS-15980
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>            Priority: Trivial
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> HDFS-15754 introduces 4 new metrics in DataNodeMetrics.  However the test 
> associated with the patch has some bugs.  This issue is to fix those bugs in 
> the tests.
> Please note that the non-test code of HDFS-15754 worked fine without any bugs.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to