[
https://issues.apache.org/jira/browse/HDFS-15990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325056#comment-17325056
]
Stephen O'Donnell commented on HDFS-15990:
------------------------------------------
The reason the sub-sections are written here, is so we can add the ability to
load them in parallel later (like with the inodes and directory sections).
However so far nobody has started that work.
> No need to write to sub_section when serialize SnapshotDiff Section
> -------------------------------------------------------------------
>
> Key: HDFS-15990
> URL: https://issues.apache.org/jira/browse/HDFS-15990
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs
> Affects Versions: 2.10.0
> Reporter: Xuze Yang
> Priority: Minor
>
> In FSImageFormatPBSnapshot.serializeSnapshotDiffSection(), the following code
> exists:
> {code:java}
> if (i % parent.getInodesPerSubSection() == 0) {
> parent.commitSubSection(headers,
> FSImageFormatProtobuf.SectionName.SNAPSHOT_DIFF_SUB);
> }{code}
> It aims to serialize SnapshotDiff information into several sub_sections(i.e.
> additional sub_sections information will be written to FileSummary Section).
> But in FSImageFormatPBSnapshot.loadSnapshotDiffSection(), it treats
> SnapshotDiffSection as a whole, rather than several sub_sections. So it's no
> need to introduce sub_sections here.
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]