[ 
https://issues.apache.org/jira/browse/HDFS-15974?focusedWorklogId=585548&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-585548
 ]

ASF GitHub Bot logged work on HDFS-15974:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Apr/21 04:19
            Start Date: 20/Apr/21 04:19
    Worklog Time Spent: 10m 
      Work Description: zhuxiangyi commented on a change in pull request #2915:
URL: https://github.com/apache/hadoop/pull/2915#discussion_r616332454



##########
File path: 
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/NamenodeBeanMetrics.java
##########
@@ -855,7 +855,7 @@ public long getNumberOfSnapshottableDirs() {
 
   @Override
   public String getEnteringMaintenanceNodes() {
-    return "N/A";
+    return null;

Review comment:
       Thanks for your review @goiri , I think returning "{}" is more friendly 
than "null". I submitted new code and added tests.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 585548)
    Time Spent: 0.5h  (was: 20m)

> RBF: Unable to display the datanode UI of the router
> ----------------------------------------------------
>
>                 Key: HDFS-15974
>                 URL: https://issues.apache.org/jira/browse/HDFS-15974
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: rbf, ui
>    Affects Versions: 3.4.0
>            Reporter: zhu
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HDFS-15358-1.patch, image-2021-04-15-11-36-47-644.png
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Clicking the Datanodes tag on the Router UI does not respond.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to