[ 
https://issues.apache.org/jira/browse/HDFS-15624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331219#comment-17331219
 ] 

Ayush Saxena commented on HDFS-15624:
-------------------------------------

End result makes sense, The way to do so can be easy. Let us just commit a one 
line Addendum to this patch, changing the layout version to 67:
{code:java}
diff --git 
a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeLayoutVersion.java
 
b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeLayoutVersion.java
index b2477466be9..0aab66b569c 100644
--- 
a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeLayoutVersion.java
+++ 
b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeLayoutVersion.java
@@ -90,7 +90,7 @@ public static boolean supports(final LayoutFeature f, final 
int lv) {
     QUOTA_BY_STORAGE_TYPE(-63, -61, "Support quota for specific storage 
types"),
     ERASURE_CODING(-64, -61, "Support erasure coding"),
     EXPANDED_STRING_TABLE(-65, -61, "Support expanded string table in 
fsimage"),
-    NVDIMM_SUPPORT(-66, -61, "Support NVDIMM storage type");
+    NVDIMM_SUPPORT(-67, -61, "Support NVDIMM storage type");
 
     private final FeatureInfo info;
{code}
post this commit HDFS-15566 with layout version as  66, Things should get 
sorted out.

>  Fix the SetQuotaByStorageTypeOp problem after updating hadoop 
> ---------------------------------------------------------------
>
>                 Key: HDFS-15624
>                 URL: https://issues.apache.org/jira/browse/HDFS-15624
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs
>    Affects Versions: 3.4.0
>            Reporter: YaYun Wang
>            Assignee: huangtianhua
>            Priority: Major
>              Labels: pull-request-available, release-blocker
>             Fix For: 3.4.0
>
>          Time Spent: 9h 40m
>  Remaining Estimate: 0h
>
> HDFS-15025 adds a new storage Type NVDIMM, changes the ordinal() of the enum 
> of StorageType. And, setting the quota by storageType depends on the 
> ordinal(), therefore, it may cause the setting of quota to be invalid after 
> upgrade.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to