[ 
https://issues.apache.org/jira/browse/HDFS-15982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339097#comment-17339097
 ] 

Ayush Saxena commented on HDFS-15982:
-------------------------------------

We can fix things as an Addendum PR, if all agree.

The basic ask is behaviour should stay same for all {{FileSystems}}. It 
shouldn't be like if I move from {{WebHdfs}} to another FS, behaviour changes, 
if other FS throws exception, we too should throw, if returns a value for 
certain case, {{WebHdfs}} should return the same. If other Fs moves to trash 
with the value set, then WebHdfs also should in that case, if nobody does that 
WebHdfs should also not do that.

If some behaviour doesn't look good or feel is important to change, Let us 
change in Hadoop-Common first, Let all filesystem adapt and we can happily 
change.

Regarding compatibility, An incompatible change is something which isn't 
suppose to be done because the applications tend to believe that behaviour 
won't change and Hadoop in general used to(not now I guess) have very high 
standards. Eg. Hive relies on rename call to see if the target exists, if it 
returns false, means target already exist, it appends then counter and then 
rename again. If someone starts throwing exception in that code will break, 
Which isn't a good thing. HDFS-13732 got reverted for just a CLI change which 
in all cases is good.

It is never like for improvements we just mark incompatible and then side-line 
the compatibility because someone feels it would be good. For Bugs, yes we do 
so if it is the last option, for which he have a flag telling sorry we had no 
choice.

Regarding the router part, Is the call going back to the router, since the path 
needs to be resolved with respect to the mount table, or is it resolving with 
respect to the Namenode itself?

> Deleted data using HTTP API should be saved to the trash
> --------------------------------------------------------
>
>                 Key: HDFS-15982
>                 URL: https://issues.apache.org/jira/browse/HDFS-15982
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>          Components: hdfs, hdfs-client, httpfs, webhdfs
>            Reporter: Bhavik Patel
>            Assignee: Viraj Jasani
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: Screenshot 2021-04-23 at 4.19.42 PM.png, Screenshot 
> 2021-04-23 at 4.36.57 PM.png
>
>          Time Spent: 12h 10m
>  Remaining Estimate: 0h
>
> If we delete the data from the Web UI then it should be first moved to 
> configured/default Trash directory and after the trash interval time, it 
> should be removed. currently, data directly removed from the system[This 
> behavior should be the same as CLI cmd]
> This can be helpful when the user accidentally deletes data from the Web UI.
> Similarly we should provide "Skip Trash" option in HTTP API as well which 
> should be accessible through Web UI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to