[
https://issues.apache.org/jira/browse/HDFS-16007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340368#comment-17340368
]
Viraj Jasani commented on HDFS-16007:
-------------------------------------
[~jwjwyoung] Would you like to take a look at PR? In addition to small
improvement, I have added this comment:
{code:java}
// Since ReplicaState (de)serialization depends on ordinal, either adding
// new value should be avoided to this enum or newly appended value should
// be handled by NameNodeLayoutVersion#Feature.
{code}
> Vulnerabilities found when serializing enum value
> -------------------------------------------------
>
> Key: HDFS-16007
> URL: https://issues.apache.org/jira/browse/HDFS-16007
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: junwen yang
> Assignee: Viraj Jasani
> Priority: Major
>
> ReplicaState enum is using ordinal to conduct serialization and
> deserialization, which is vulnerable to the order, to cause issues similar to
> HDFS-15624.
> To avoid it, either adding comments to let later developer not to change this
> enum, or add index checking in the read and getState function to avoid index
> out of bound error.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
