[ 
https://issues.apache.org/jira/browse/HDFS-16003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341776#comment-17341776
 ] 

Qi Zhu commented on HDFS-16003:
-------------------------------

LGTM +1. 

> ProcessReport print invalidatedBlocks should judge debug level at first
> -----------------------------------------------------------------------
>
>                 Key: HDFS-16003
>                 URL: https://issues.apache.org/jira/browse/HDFS-16003
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namanode
>    Affects Versions: 3.3.0
>            Reporter: lei w
>            Assignee: lei w
>            Priority: Minor
>         Attachments: HDFS-16003.001.path, HDFS-16003.patch
>
>
> In BlockManager#processReport( ) method, we will print invalidated blocks if 
> log level is debug。We always traverse this invalidatedBlocks list without 
> considering the log level。I suggest to give priority to the log level before 
> printing, which can save the time of traversal if log  level is info.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to