[
https://issues.apache.org/jira/browse/HDFS-15973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342772#comment-17342772
]
Íñigo Goiri commented on HDFS-15973:
------------------------------------
* checkRouterRenamePath() looks a little too generic. In reality is checking
just for snapshots and it doesn't use all the paths. In addition, it bases its
functionality in exception. Can we make it a little simpler?
* All the checks we added regarding permissions might be better in a separate
method that we call instead of this done in the regular code and then call an
internal.
* Can we add some break lines in testPermissionCheck() so the code "breaths a
little"? I would even split into multiple test functions but that might be too
much. I'm in the border of proposing a new class where each case is a test
method.
> RBF: Add permission check before doting router federation rename.
> -----------------------------------------------------------------
>
> Key: HDFS-15973
> URL: https://issues.apache.org/jira/browse/HDFS-15973
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jinglun
> Assignee: Jinglun
> Priority: Major
> Attachments: HDFS-15973.001.patch, HDFS-15973.002.patch,
> HDFS-15973.003.patch, HDFS-15973.004.patch, HDFS-15973.005.patch
>
>
> The router federation rename is lack of permission check. It is a security
> issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
