[
https://issues.apache.org/jira/browse/HDFS-15877?focusedWorklogId=597964&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597964
]
ASF GitHub Bot logged work on HDFS-15877:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/May/21 18:17
Start Date: 17/May/21 18:17
Worklog Time Spent: 10m
Work Description: ferhui commented on pull request #2747:
URL: https://github.com/apache/hadoop/pull/2747#issuecomment-841928897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 597964)
Time Spent: 2h (was: 1h 50m)
> BlockReconstructionWork should resetTargets() before
> BlockManager#validateReconstructionWork return false
> ---------------------------------------------------------------------------------------------------------
>
> Key: HDFS-15877
> URL: https://issues.apache.org/jira/browse/HDFS-15877
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Haiyang Hu
> Assignee: Haiyang Hu
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> BlockReconstructionWork should resetTargets() before
> BlockManager#validateReconstructionWork return false
> the related code is in BlockManager.java
> {code:java}
> // code placeholder
> private boolean validateReconstructionWork(BlockReconstructionWork rw) {
> BlockInfo block = rw.getBlock();
> int priority = rw.getPriority();
> ...
> if (block.isDeleted() || !block.isCompleteOrCommitted()) {
> neededReconstruction.remove(block, priority);
> rw.resetTargets();
> return false;
> }
> // do not schedule more if enough replicas is already pending
> ...
> if (hasEnoughEffectiveReplicas(block, numReplicas, pendingNum)) {
> neededReconstruction.remove(block, priority);
> rw.resetTargets();
> blockLog.debug("BLOCK* Removing {} from neededReconstruction as" +
> " it has enough replicas", block);
> return false;
> }
> DatanodeStorageInfo[] targets = rw.getTargets();
> BlockPlacementStatus placementStatus = getBlockPlacementStatus(block);
> if ((numReplicas.liveReplicas() >= requiredRedundancy) &&
> (!placementStatus.isPlacementPolicySatisfied())) {
> BlockPlacementStatus newPlacementStatus =
> getBlockPlacementStatus(block, targets);
> if (!newPlacementStatus.isPlacementPolicySatisfied() &&
> (newPlacementStatus.getAdditionalReplicasRequired() >=
> placementStatus.getAdditionalReplicasRequired())) {
> ...
> //Here to add rw.resetTargets();
> return false;
> }
>
> rw.setNotEnoughRack();
> }
> ...
> return true;
> }
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
