[ https://issues.apache.org/jira/browse/HDFS-16027?focusedWorklogId=598083&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-598083 ]
ASF GitHub Bot logged work on HDFS-16027: ----------------------------------------- Author: ASF GitHub Bot Created on: 17/May/21 18:30 Start Date: 17/May/21 18:30 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on pull request #3018: URL: https://github.com/apache/hadoop/pull/3018#issuecomment-842389544 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 0m 53s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 1s | | codespell was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | |||| _ branch-3.3 Compile Tests _ | | +1 :green_heart: | mvninstall | 32m 44s | | branch-3.3 passed | | +1 :green_heart: | compile | 1m 13s | | branch-3.3 passed | | +1 :green_heart: | checkstyle | 0m 46s | | branch-3.3 passed | | +1 :green_heart: | mvnsite | 1m 21s | | branch-3.3 passed | | +1 :green_heart: | javadoc | 1m 23s | | branch-3.3 passed | | +1 :green_heart: | spotbugs | 3m 13s | | branch-3.3 passed | | +1 :green_heart: | shadedclient | 20m 25s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 1m 14s | | the patch passed | | +1 :green_heart: | compile | 1m 9s | | the patch passed | | +1 :green_heart: | javac | 1m 9s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | -0 :warning: | checkstyle | 0m 39s | [/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3018/1/artifact/out/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt) | hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1) | | +1 :green_heart: | mvnsite | 1m 12s | | the patch passed | | +1 :green_heart: | javadoc | 1m 17s | | the patch passed | | +1 :green_heart: | spotbugs | 3m 16s | | the patch passed | | +1 :green_heart: | shadedclient | 19m 44s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | -1 :x: | unit | 208m 48s | [/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3018/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt) | hadoop-hdfs in the patch passed. | | +1 :green_heart: | asflicense | 0m 37s | | The patch does not generate ASF License warnings. | | | | 297m 3s | | | | Reason | Tests | |-------:|:------| | Failed junit tests | hadoop.hdfs.TestRollingUpgrade | | | hadoop.hdfs.server.balancer.TestBalancer | | | hadoop.hdfs.server.datanode.TestDirectoryScanner | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3018/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/3018 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell | | uname | Linux 5819f7462518 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | branch-3.3 / ed82894f7c42f92a1b2c6c73f9a94d2d7ea59781 | | Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~18.04-b10 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3018/1/testReport/ | | Max. process+thread count | 2057 (vs. ulimit of 5500) | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3018/1/console | | versions | git=2.17.1 maven=3.6.0 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 598083) Time Spent: 40m (was: 0.5h) > HDFS-15245 breaks source code compatibility between 3.3.0 and 3.3.1. > --------------------------------------------------------------------- > > Key: HDFS-16027 > URL: https://issues.apache.org/jira/browse/HDFS-16027 > Project: Hadoop HDFS > Issue Type: Bug > Components: journal-node, ui > Affects Versions: 3.3.1 > Reporter: Wei-Chiu Chuang > Assignee: Wei-Chiu Chuang > Priority: Blocker > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > Ok, this one is on me. > JournalNodeMXBean is a Public, Evolving interface. > But HDFS-15245 was cherrypicked to branch-3.3 which breaks source > compatibility between 3.3.0 and 3.3.1 by adding the following three methods: > {noformat} > /** > * Get host and port of JournalNode. > * > * @return colon separated host and port. > */ > String getHostAndPort(); > /** > * Get list of the clusters of JournalNode's journals > * as one JournalNode may support multiple clusters. > * > * @return list of clusters. > */ > List<String> getClusterIds(); > /** > * Gets the version of Hadoop. > * > * @return the version of Hadoop. > */ > String getVersion(); > {noformat} > api checker error: > {quote} > Recompilation of a client program may be terminated with the message: a > client class C is not abstract and does not override abstract method > getClusterIds ( ) in JournalNodeMXBean. > {quote} -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org