[ 
https://issues.apache.org/jira/browse/HDFS-16028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17350240#comment-17350240
 ] 

zhuobin zheng commented on HDFS-16028:
--------------------------------------

HI [~zhuqi], thanks for your review and  advice! Submit 003 patch for resolve 
these problem.
{code:java}
1. We'd better add an enable flag to trigger this besides null check.
{code}
I think enable flag is redundant. And i don't add the flag in 003.
{code:java}
2. We should also add the new conf in core-default.xml. 
{code}
Done in 003.
{code:java}
3. We should add some doc for getTrashHome method consistent with 
getHomeDirectory.
{code}
Done in 003.

 

> Add a configuration item for special trash dir
> ----------------------------------------------
>
>                 Key: HDFS-16028
>                 URL: https://issues.apache.org/jira/browse/HDFS-16028
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>            Reporter: zhuobin zheng
>            Assignee: zhuobin zheng
>            Priority: Minor
>              Labels: pull-request-available
>         Attachments: HDFS-16028.001.patch, HDFS-16028.002.patch, 
> HDFS-16028.003.patch
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In some situation, We don't want to put trash in homedir. like:
>  # Immediately reduce the quota occupation of the home directory
>  # In RBF:  We want to make the directory mounting strategy of trash 
> different from the home directory and we don't want mount it per user
> This patch add the option "fs.trash.dir" to special the trash dir( 
> ${fs.trash.dir}/$USER/.Trash)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to