[ https://issues.apache.org/jira/browse/HDFS-16040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351510#comment-17351510 ]
Konstantin Shvachko commented on HDFS-16040: -------------------------------------------- I checked that the test is fails without the fix and passes with it. I was wondering if the code correct;y counts the queue time for Observer. That is takes into account the time the call was requeued. It seems to me that it does. [~simbadzina] could you please double-check. I guess there will be some checkstyle warnings when Jenkins finishes. > RpcQueueTime metric counts requeued calls as unique events. > ----------------------------------------------------------- > > Key: HDFS-16040 > URL: https://issues.apache.org/jira/browse/HDFS-16040 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs > Affects Versions: 2.10.0, 3.3.0 > Reporter: Simbarashe Dzinamarira > Assignee: Simbarashe Dzinamarira > Priority: Major > Attachments: HDFS-16040.001.patch, HDFS-16040.002.patch > > > The RpcQueueTime metric is updated every time a call is re-queued while > waiting for the server state to reach the call's client's state ID. This is > in contrast to RpcProcessingTime which is only updated when the call if > finally processed. > On the Observer NameNode this can result in RpcQueueTimeNumOps being much > larger than RpcProcessingTimeNumOps. The re-queueing is an internal > optimization to avoid blocking and shouldn't result in an inflated metric. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org