[
https://issues.apache.org/jira/browse/HDFS-16048?focusedWorklogId=605681&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-605681
]
ASF GitHub Bot logged work on HDFS-16048:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jun/21 06:15
Start Date: 03/Jun/21 06:15
Worklog Time Spent: 10m
Work Description: tomscut commented on a change in pull request #3062:
URL: https://github.com/apache/hadoop/pull/3062#discussion_r644513026
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NetworkTopologyServlet.java
##########
@@ -90,7 +90,7 @@ public void doGet(HttpServletRequest request,
HttpServletResponse response)
* @param leaves leaves nodes under base scope
* @param format the response format
*/
- public void printTopology(PrintStream stream, List<Node> leaves,
+ private void printTopology(PrintStream stream, List<Node> leaves,
Review comment:
> Why not just override?
Because the arguments of the two methods are a little different, I'll fix
it. Thank you for pointing that out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 605681)
Time Spent: 2h (was: 1h 50m)
> RBF: Print network topology on the router web
> ---------------------------------------------
>
> Key: HDFS-16048
> URL: https://issues.apache.org/jira/browse/HDFS-16048
> Project: Hadoop HDFS
> Issue Type: Wish
> Reporter: tomscut
> Assignee: tomscut
> Priority: Minor
> Labels: pull-request-available
> Attachments: topology-json.jpg, topology-text.jpg
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> In order to query the network topology information conveniently, we can print
> it on the router web. It's related to HDFS-15970.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
