[
https://issues.apache.org/jira/browse/HDFS-15971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17360371#comment-17360371
]
Jim Brennan commented on HDFS-15971:
------------------------------------
[~gautham], thanks for your response. I have upgraded everything on my linux VM
based on what is in the centos 7 docker image, and I have been able to get
native hadoop to compile.
I think improving the Windows build experience is a worthy goal. I am a bit
concerned about how much of an upgrade this is on the linux (gcc) side, going
from 4.8.5 to 9.3.0. Maybe this is OK to do in trunk, but if the intention is
to push this back to earlier branch-3 branches, that might be a problem for
groups using those branches. I'm not sure what the guidelines are for upgrading
the build environment in minor releases. As you say, maybe it is worth it in
this case.
Note that I can build trunk with 4.8.5 if I revert the change to this line in
build_libhdfs_test in hadoop-hdfs-native-client/.../src/CMakeLists.txt:
{code:java}
add_executable("${NAME}_${LIBRARY}" $<TARGET_OBJECTS:x_platform_obj_c_api>
$<TARGET_OBJECTS:x_platform_obj> ${FILES})
{code}
But I think that just prevents it from building the x_platform_obj.
I'm not sure if it was building the x_platform stuff prior to this commit, or
if it was just silently failing with 4.8.5?
{quote}*I'm also puzzled by this failing check. This did not fail on 4.8.5
before this commit (and the warning message hasn't been updated either):*
This is coming from here. Let me take a look at this and get back to you.
Nevertheless, we don't face this issue when GCC is upgraded to 9.3.0.
{quote}
I am curious to see what you find. I would like to understand better what
specifically in this commit is causing this check to fail with gcc 4.8.5. It
wasn't failing before, and you didn't modify this check.
> Make mkstemp cross platform
> ---------------------------
>
> Key: HDFS-15971
> URL: https://issues.apache.org/jira/browse/HDFS-15971
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: libhdfs++
> Affects Versions: 3.4.0
> Reporter: Gautham Banasandra
> Assignee: Gautham Banasandra
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Attachments: Dockerfile_centos_7, build-log.zip, commit-details.txt
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> mkstemp isn't available in Visual C++. Need to make it cross platform.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
