[
https://issues.apache.org/jira/browse/HDFS-16063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Mollitor updated HDFS-16063:
----------------------------------
Description:
The class {{EditLogFileInputStream}} is logged at DEBUG level, but has no
{{toString}} method, so the logging is of limited value. Also, put the DEBUG
statement behind some guards since it's printing an unbounded list of items.
https://github.com/apache/hadoop/blob/eefa664fea1119a9c6e3ae2d2ad3069019fbd4ef/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java#L895
Just need the following:
{code:java}
private final LogSource log;
private final long firstTxId;
private final long lastTxId;
private final boolean isInProgress;
private int maxOpSize;
private State state = State.UNINIT;
private int logVersion = 0;
{code}
was:
The class {{EditLogFileInputStream}} is logged at DEBUG level, but has no
{{toString}} method, so the logging is of limited value. Also, put the DEBUG
statement behind some guards since it's printing an unbounded list of items.
https://github.com/apache/hadoop/blob/eefa664fea1119a9c6e3ae2d2ad3069019fbd4ef/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java#L895
> Add toString to EditLogFileInputStream
> --------------------------------------
>
> Key: HDFS-16063
> URL: https://issues.apache.org/jira/browse/HDFS-16063
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: David Mollitor
> Priority: Minor
>
> The class {{EditLogFileInputStream}} is logged at DEBUG level, but has no
> {{toString}} method, so the logging is of limited value. Also, put the DEBUG
> statement behind some guards since it's printing an unbounded list of items.
> https://github.com/apache/hadoop/blob/eefa664fea1119a9c6e3ae2d2ad3069019fbd4ef/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java#L895
> Just need the following:
> {code:java}
> private final LogSource log;
> private final long firstTxId;
> private final long lastTxId;
> private final boolean isInProgress;
> private int maxOpSize;
> private State state = State.UNINIT;
> private int logVersion = 0;
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
