[
https://issues.apache.org/jira/browse/HDFS-16068?focusedWorklogId=611093&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-611093
]
ASF GitHub Bot logged work on HDFS-16068:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jun/21 01:31
Start Date: 15/Jun/21 01:31
Worklog Time Spent: 10m
Work Description: tasanuma commented on pull request #3104:
URL: https://github.com/apache/hadoop/pull/3104#issuecomment-861103245
Writing the unit test is not easy because `cachedConnection` is private. But
the fix is clear and safe. So I don't think the unit test is required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 611093)
Time Spent: 20m (was: 10m)
> WebHdfsFileSystem has a possible connection leak in connection with HttpFS
> --------------------------------------------------------------------------
>
> Key: HDFS-16068
> URL: https://issues.apache.org/jira/browse/HDFS-16068
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Takanobu Asanuma
> Assignee: Takanobu Asanuma
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When we use WebHdfsFileSystem for HttpFS, some connections remain for a while
> after the filesystems are closed until GC runs. After investigating it for a
> while, I found that there is a potential connection leak in WebHdfsFileSystem.
> {code:java}
> // Close both the InputStream and the connection.
> @VisibleForTesting
> void closeInputStream(RunnerState rs) throws IOException {
> if (in != null) {
> IOUtils.close(cachedConnection);
> in = null;
> }
> cachedConnection = null;
> runnerState = rs;
> }
> {code}
> In the above code, if the variable of {{in}} is null and {{cachedConnection}}
> is not null, {{cachedConnection}} doesn't close and the connection remains. I
> think this is the cause of our problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
