[
https://issues.apache.org/jira/browse/HDFS-16061?focusedWorklogId=611759&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-611759
]
ASF GitHub Bot logged work on HDFS-16061:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jun/21 07:09
Start Date: 16/Jun/21 07:09
Worklog Time Spent: 10m
Work Description: ayushtkn commented on a change in pull request #3095:
URL: https://github.com/apache/hadoop/pull/3095#discussion_r652409047
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/DFSTestUtil.java
##########
@@ -206,6 +206,8 @@
private static final String[] dirNames = {
"zero", "one", "two", "three", "four", "five", "six", "seven", "eight",
"nine"
};
+
+ private static final int WAIT_REPLICATION_ATTEMPTS = 40;
Review comment:
Why you have pulled this up? Means nobody apart from `waitReplication `
method is using it? We could have kept it there itself, the variable is
private, no one can change it also
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 611759)
Time Spent: 40m (was: 0.5h)
> DFTestUtil.waitReplication can produce false positives
> ------------------------------------------------------
>
> Key: HDFS-16061
> URL: https://issues.apache.org/jira/browse/HDFS-16061
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs
> Reporter: Ahmed Hussein
> Assignee: Ahmed Hussein
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> While checking the intermittent failure in
> TestBalancerRPCDelay#testBalancerRPCDelayQpsDefault described in HDFS-15146,
> I found that the implementation of waitReplication is incorrect.
> In the last iteration, when {{correctReplFactor}} is {{false}}, the thread
> sleeps for 1 second, then a {{TimeoutException}} is thrown without check
> whether the replication was complete in the last second.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
