[
https://issues.apache.org/jira/browse/HDFS-15785?focusedWorklogId=612001&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-612001
]
ASF GitHub Bot logged work on HDFS-15785:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jun/21 21:07
Start Date: 18/Jun/21 21:07
Worklog Time Spent: 10m
Work Description: LeonGao91 commented on a change in pull request #2639:
URL: https://github.com/apache/hadoop/pull/2639#discussion_r654073694
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSUtil.java
##########
@@ -647,6 +634,58 @@ public static String addKeySuffixes(String key, String...
suffixes) {
getNNLifelineRpcAddressesForCluster(Configuration conf)
throws IOException {
+ Collection<String> parentNameServices = getParentNameServices(conf);
+
+ return getAddressesForNsIds(conf, parentNameServices, null,
+ DFS_NAMENODE_LIFELINE_RPC_ADDRESS_KEY);
+ }
+
+ //
+ /**
+ * Returns the configured address for all NameNodes in the cluster.
+ * This is similar with DFSUtilClient.getAddressesForNsIds()
+ * but can access DFSConfigKeys.
+ *
+ * @param conf configuration
+ * @param defaultAddress default address to return in case key is not found.
+ * @param keys Set of keys to look for in the order of preference
+ *
+ * @return a map(nameserviceId to map(namenodeId to InetSocketAddress))
+ */
+ static Map<String, Map<String, InetSocketAddress>> getAddressesForNsIds(
Review comment:
Yeah that sounds better, let me try it out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 612001)
Time Spent: 2h 40m (was: 2.5h)
> Datanode to support using DNS to resolve nameservices to IP addresses to get
> list of namenodes
> ----------------------------------------------------------------------------------------------
>
> Key: HDFS-15785
> URL: https://issues.apache.org/jira/browse/HDFS-15785
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Reporter: Leon Gao
> Assignee: Leon Gao
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Currently as HDFS supports observers, multiple-standby and router, the
> namenode hosts are changing frequently in large deployment, we can consider
> supporting https://issues.apache.org/jira/browse/HDFS-14118 on datanode to
> reduce the need to update config frequently on all datanodes. In that case,
> datanode and clients can use the same set of config as well.
> Basically we can resolve the DNS and generate namenode for each IP behind it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
