[ 
https://issues.apache.org/jira/browse/HDFS-16067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369828#comment-17369828
 ] 

Ayush Saxena commented on HDFS-16067:
-------------------------------------

* What are we doing with this:

{code:java}
      HdfsFileStatus status = blkWithStatus.getFileStatus();
{code}
the {{status}} seems to be unused?
 * For EC files we need to pass the new block flag, I guess we should allow an 
option to use the new block flag as well for append. erasure coded files can 
not be appended without that. for replicated files also the new block flag is 
used in a bunch of cases. Good to add an option for that.
 * Possible to extend a test case in {{TestNNThroughputBenchmark}}
 * nit: Break line after override

{code:java}
849    @Override long executeOp(int daemonId, int inputIdx, String ignore)
{code}

> Support Append API in NNThroughputBenchmark
> -------------------------------------------
>
>                 Key: HDFS-16067
>                 URL: https://issues.apache.org/jira/browse/HDFS-16067
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Renukaprasad C
>            Assignee: Renukaprasad C
>            Priority: Minor
>         Attachments: HDFS-16067.001.patch, HDFS-16067.002.patch, 
> HDFS-16067.003.patch, HDFS-16067.004.patch
>
>
> Append API needs to be added into NNThroughputBenchmark tool.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to