[ 
https://issues.apache.org/jira/browse/HDFS-2743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178808#comment-13178808
 ] 

Ivan Kelly commented on HDFS-2743:
----------------------------------

{qoute}-1 tests included. The patch doesn't appear to include any new or 
modified tests.{quote}
Change is to packaging, no test required.

{quote}-1 javadoc. The javadoc tool appears to have generated 20 warning 
messages.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) 
warnings.
{quote}
This are not within the bkjournal contrib module.

{quote}
-1 release audit. The applied patch generated 1 release audit warnings (more 
than the trunk's current 0 warnings).
{quote}
This relates to: <br/>
 !????? 
/home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/dev-support/findbugsExcludeFile.xml
                
> Streamline usage of bookkeeper journal manager
> ----------------------------------------------
>
>                 Key: HDFS-2743
>                 URL: https://issues.apache.org/jira/browse/HDFS-2743
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 0.24.0
>
>         Attachments: HDFS-2743.diff
>
>
> The current method of installing bkjournal manager involves generating a 
> tarball, and extracting it with special flags over the hdfs distribution. 
> This is cumbersome and prone to being broken by other changes (see 
> https://svn.apache.org/repos/asf/hadoop/common/trunk@1220940). I think a 
> cleaner way to doing this is to generate a single jar that can be placed in 
> the lib dir of hdfs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to