[
https://issues.apache.org/jira/browse/HDFS-16118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17384557#comment-17384557
]
JiangHua Zhu commented on HDFS-16118:
-------------------------------------
[~weichiu] [~sodonnell] [~hexiaoqiao], do you have any new suggestions?
Also, if possible, please help review the code I submitted. thank you very much.
> Improve the number of handlers that initialize
> NameNodeRpcServer#clientRpcServer
> --------------------------------------------------------------------------------
>
> Key: HDFS-16118
> URL: https://issues.apache.org/jira/browse/HDFS-16118
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: JiangHua Zhu
> Assignee: JiangHua Zhu
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When initializing NameNodeRpcServer, if the value of
> dfs.namenode.lifeline.handler.count is set to be less than 0 (such as -1, of
> course, this is rare), when determining the number of lifeline RPC handlers,
> it will be based on dfs.namenode.handler .count * lifelineHandlerRatio is
> determined.
> The code can be found:
> int lifelineHandlerCount = conf.getInt(
> DFS_NAMENODE_LIFELINE_HANDLER_COUNT_KEY, 0);
> if (lifelineHandlerCount <= 0) {
> float lifelineHandlerRatio = conf.getFloat(
> DFS_NAMENODE_LIFELINE_HANDLER_RATIO_KEY,
> DFS_NAMENODE_LIFELINE_HANDLER_RATIO_DEFAULT);
> lifelineHandlerCount = Math.max(
> (int)(handlerCount * lifelineHandlerRatio), 1);
> }
> When this happens, the handlerCount should be subtracted from the
> lifelineHandlerCount when in fact it doesn't.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
