[
https://issues.apache.org/jira/browse/HDFS-16151?focusedWorklogId=632663&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-632663
]
ASF GitHub Bot logged work on HDFS-16151:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Aug/21 01:56
Start Date: 03/Aug/21 01:56
Worklog Time Spent: 10m
Work Description: jianghuazhu opened a new pull request #3256:
URL: https://github.com/apache/hadoop/pull/3256
…e2#Server().
## NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 632663)
Remaining Estimate: 0h
Time Spent: 10m
> Improve the parameter comments related to ProtobufRpcEngine2#Server()
> ---------------------------------------------------------------------
>
> Key: HDFS-16151
> URL: https://issues.apache.org/jira/browse/HDFS-16151
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: JiangHua Zhu
> Assignee: JiangHua Zhu
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Now missing some parameter comments related to ProtobufRpcEngine2#Server(),
> as follows:
> /**
> * Construct an RPC server.
> *
> * @param protocolClass the class of protocol
> * @param protocolImpl the protocolImpl whose methods will be called
> * @param conf the configuration to use
> * @param bindAddress the address to bind on to listen for connection
> * @param port the port to listen for connections on
> * @param numHandlers the number of method handler threads to run
> * @param verbose whether each call should be logged
> * @param portRangeConfig A config parameter that can be used to restrict
> * the range of ports used when port is 0 (an ephemeral port)
> * @param alignmentContext provides server state info on client responses
> */
> public Server(Class<?> protocolClass, Object protocolImpl,
> Configuration conf, String bindAddress, int port, int numHandlers,
> int numReaders, int queueSizePerHandler, boolean verbose,
> SecretManager<? extends TokenIdentifier> secretManager,
> String portRangeConfig, AlignmentContext alignmentContext)
> throws IOException {
> super(protocolClass, protocolImpl, conf, bindAddress, port, numHandlers,
> numReaders, queueSizePerHandler, verbose, secretManager,
> portRangeConfig, alignmentContext);
> }
> The description of numReaders, queueSizePerHandler, and secretManager is
> missing here.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
