[
https://issues.apache.org/jira/browse/HDFS-12188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17398097#comment-17398097
]
Ahmed Hussein commented on HDFS-12188:
--------------------------------------
Hi [~vjasani]
Thanks for taking a look at this jira. I have few comments:
* can you please describe what the purpose of the change to resolve the issue?
* if it is not evident that the changes are resolving the original issue this
ticket was filed for, then it would be better to open a new jira , then later
this very jira can be resolved. You can also link this jira to the new one. In
That way, anyone who was aware of the problem would be able to understand that
it has been resolved.
* Changing title/description for an old jira is not very good idea (unless
there was error or typo) because it will be difficult for other developers to
see that what they have filed/contributed to has been resolved. They need to
guess then look inside the transitions/history of the jiras to find what they
have been looking for.
* For future jiras, I personally prefer that a new jira is filed leaving the
existing ones as they are (until they are marked as resolved).
> De-flake testDecommissionStatus
> -------------------------------
>
> Key: HDFS-12188
> URL: https://issues.apache.org/jira/browse/HDFS-12188
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Brahma Reddy Battula
> Assignee: Ajay Kumar
> Priority: Major
> Labels: pull-request-available
> Attachments: TestFailure_Log.txt
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> {noformat}
> java.lang.AssertionError: Unexpected num under-replicated blocks expected:<3>
> but was:<4>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:555)
> at
> org.apache.hadoop.hdfs.server.namenode.TestDecommissioningStatus.checkDecommissionStatus(TestDecommissioningStatus.java:144)
> at
> org.apache.hadoop.hdfs.server.namenode.TestDecommissioningStatus.testDecommissionStatus(TestDecommissioningStatus.java:240)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
