[
https://issues.apache.org/jira/browse/HDFS-16174?focusedWorklogId=638347&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-638347
]
ASF GitHub Bot logged work on HDFS-16174:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Aug/21 18:36
Start Date: 16/Aug/21 18:36
Worklog Time Spent: 10m
Work Description: goiri commented on a change in pull request #3303:
URL: https://github.com/apache/hadoop/pull/3303#discussion_r689769484
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tests/configuration_test.h
##########
@@ -114,105 +111,6 @@ void writeDamagedConfig(const std::string& filename,
Args... args) {
out.open(filename);
out << stream.rdbuf();
}
-
-// TempDir: is deleted on destruction
-class TempFile {
Review comment:
Those are valuable but let's make this a refactor PR to make it more
explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 638347)
Time Spent: 1h 20m (was: 1h 10m)
> Refactor TempFile and TempDir
> -----------------------------
>
> Key: HDFS-16174
> URL: https://issues.apache.org/jira/browse/HDFS-16174
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: libhdfs++
> Affects Versions: 3.4.0
> Reporter: Gautham Banasandra
> Assignee: Gautham Banasandra
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> In C++, we generally do the declaration in the header files and the
> corresponding implementation in the .cc files. Here we see that the
> implementation of TempFile and TempDir are done in configuration_test.h
> itself. This offers no benefit and the compilation of TempFile and TempDir
> classes are duplicated for every #include of the configuration_test.h header.
> Thus, we need to implement it in separate cc files to avoid this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
