[
https://issues.apache.org/jira/browse/HDFS-16197?focusedWorklogId=646672&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646672
]
ASF GitHub Bot logged work on HDFS-16197:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Sep/21 05:28
Start Date: 05/Sep/21 05:28
Worklog Time Spent: 10m
Work Description: jianghuazhu commented on a change in pull request #3357:
URL: https://github.com/apache/hadoop/pull/3357#discussion_r702368621
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
##########
@@ -4639,6 +4639,10 @@ public FSEditLog getEditLog() {
return getFSImage().getEditLog();
}
+ public NNStorage getNNStorage() {
Review comment:
Thanks @ayushtkn for your comments.
Yes, it's about refactoring. I see a lot of places getting NNStorage through
FSNamesystem, and I think it makes sense for FSNamesystem to do so.
I will go on working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 646672)
Time Spent: 1h 40m (was: 1.5h)
> Simplify getting NNStorage in FSNamesystem
> ------------------------------------------
>
> Key: HDFS-16197
> URL: https://issues.apache.org/jira/browse/HDFS-16197
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: JiangHua Zhu
> Assignee: JiangHua Zhu
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> In FSNamesystem, there are many places where NNStorage needs to be used
> (according to preliminary statistics, there are 15 times), and these places
> are obtained using "getFSImage().getStorage()". We should try to use a
> simpler way.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
